From: Panu Matilainen <pmatilai@redhat.com>
Date: Mon, 7 Dec 2009 10:38:39 +0000 (+0200)
Subject: ts.check() is supposed to return empty list when no problems
X-Git-Tag: rpm-4.8.0-beta1~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=75c171f20891e58f1f14f37bba8e3e13b47bb783;p=platform%2Fupstream%2Frpm.git

ts.check() is supposed to return empty list when no problems
---

diff --git a/python/rpm/transaction.py b/python/rpm/transaction.py
index 2c836f3..359d62c 100644
--- a/python/rpm/transaction.py
+++ b/python/rpm/transaction.py
@@ -104,13 +104,9 @@ class TransactionSet(_rpmts):
     def check(self, *args, **kwds):
         _rpmts.check(self, *args, **kwds)
 
-        probs = self.problems()
-        if not probs:
-            return None
-
         # compatibility: munge problem strings into dependency tuples of doom
         res = []
-        for p in probs:
+        for p in self.problems():
             # is it anything we need to care about?
             if p.type == rpm.RPMPROB_CONFLICT:
                 sense = rpm.RPMDEP_SENSE_CONFLICTS