From: Shane Kearns <ext-shane.2.kearns@nokia.com>
Date: Tue, 6 Mar 2012 11:19:33 +0000 (+0000)
Subject: Mark tst_QNetworkReply::getThenDeleteObject as unstable
X-Git-Tag: qt-v5.0.0-alpha1~482
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=75ab89d4d6e68fd5451d0f2335c95d76d3987c10;p=profile%2Fivi%2Fqtbase.git

Mark tst_QNetworkReply::getThenDeleteObject as unstable

It's unstable on all platforms, because the reply can be finished
due to a race with the http thread. It isn't crashing (which the
test was trying to test for), but rather the QVERIFY(!reply->isFinished())
fails, which is an inconclusive verdict.

Change-Id: Ib815a7cedd220544a0c9cb83023e3334df4a0fb3
Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
---

diff --git a/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp b/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp
index cc65ca2..438cf86 100644
--- a/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp
+++ b/tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp
@@ -5632,6 +5632,7 @@ void tst_QNetworkReply::getAndThenDeleteObject_data()
 
 void tst_QNetworkReply::getAndThenDeleteObject()
 {
+    QSKIP("unstable test - reply may be finished too early");
     // yes, this will leak if the testcase fails. I don't care. It must not fail then :P
     QNetworkAccessManager *manager = new QNetworkAccessManager();
     QNetworkRequest request("http://" + QtNetworkSettings::serverName() + "/qtest/bigfile");