From: Steve MacLean Date: Thu, 28 Mar 2019 00:15:45 +0000 (-0400) Subject: ALC Enhancement nits (#23506) X-Git-Tag: accepted/tizen/unified/20190813.215958~54^2~71 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=75250f4edf8e6142e2e70fb7b3966bf2348fe0e1;p=platform%2Fupstream%2Fcoreclr.git ALC Enhancement nits (#23506) isCollectible default should be false String should be string --- diff --git a/src/System.Private.CoreLib/shared/System/Reflection/Assembly.cs b/src/System.Private.CoreLib/shared/System/Reflection/Assembly.cs index c54e39f..9b3a9d8 100644 --- a/src/System.Private.CoreLib/shared/System/Reflection/Assembly.cs +++ b/src/System.Private.CoreLib/shared/System/Reflection/Assembly.cs @@ -254,7 +254,7 @@ namespace System.Reflection if (s_loadfile.TryGetValue(normalizedPath, out result)) return result; - AssemblyLoadContext alc = new IndividualAssemblyLoadContext(String.Format("Assembly.LoadFile({0})", path)); + AssemblyLoadContext alc = new IndividualAssemblyLoadContext(string.Format("Assembly.LoadFile({0})", path)); result = alc.LoadFromAssemblyPath(normalizedPath); s_loadfile.Add(normalizedPath, result); } diff --git a/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs b/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs index 4be5218..835c5c6 100644 --- a/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs +++ b/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs @@ -52,7 +52,7 @@ namespace System.Runtime.Loader { } - public AssemblyLoadContext(string name, bool isCollectible = true) : this(false, isCollectible, name) + public AssemblyLoadContext(string name, bool isCollectible = false) : this(false, isCollectible, name) { } @@ -420,7 +420,7 @@ namespace System.Runtime.Loader internal sealed class IndividualAssemblyLoadContext : AssemblyLoadContext { - internal IndividualAssemblyLoadContext(String name) : base(false, false, name) + internal IndividualAssemblyLoadContext(string name) : base(false, false, name) { } }