From: greatim Date: Wed, 2 Apr 2014 02:19:23 +0000 (+0900) Subject: [Title] fix potential bug X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74f27d6514fcc43020a9b6df1ca692470a2f3ed6;p=sdk%2Ftools%2Fdynamic-analyzer.git [Title] fix potential bug [Desc.] [Issue] --- diff --git a/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/Application.java b/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/Application.java index 1a963ac..257a2eb 100755 --- a/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/Application.java +++ b/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/Application.java @@ -29,6 +29,7 @@ package org.tizen.dynamicanalyzer.workbench; import java.io.File; import java.io.FileOutputStream; import java.io.PrintStream; +import java.net.MalformedURLException; import java.net.URL; import java.text.SimpleDateFormat; import java.util.ArrayList; @@ -62,9 +63,14 @@ public class Application implements IApplication { if (pathValidness) { // set workspace directory for dynamic analyzer + // why? Location instanceLoc = Platform.getInstanceLocation(); String path = PathManager.DA_INSTALL_PATH + File.separator; - instanceLoc.set(new URL("file", null, path), false); + try { + instanceLoc.set(new URL("file", null, path), false); + } catch (MalformedURLException e) { + e.printStackTrace(); + } // set log postfix SimpleDateFormat format = new SimpleDateFormat( diff --git a/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/LayoutManager.java b/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/LayoutManager.java index 13033b6..f2ce563 100644 --- a/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/LayoutManager.java +++ b/org.tizen.dynamicanalyzer.workbench/src/org/tizen/dynamicanalyzer/workbench/LayoutManager.java @@ -24,7 +24,7 @@ public class LayoutManager { public static void createComposite(IWorkbenchWindowConfigurer configurer, Shell shell) { - + // Sets shell layout. final FillLayout shellLayout = new FillLayout(); shellLayout.marginHeight = 0; @@ -41,24 +41,23 @@ public class LayoutManager { // create page composite with base composite Control page = configurer.createPageComposite(baseComposite); + if (null != page) { + // layout each composite + FormData data = new FormData(); + data.top = new FormAttachment(0, 0); + data.left = new FormAttachment(0, 0); + data.right = new FormAttachment(100, 0); + data.height = 38; + toolbarComposite.setLayoutData(data); - // layout each composite - FormData data = new FormData(); - data.top = new FormAttachment(0, 0); - data.left = new FormAttachment(0, 0); - data.right = new FormAttachment(100, 0); - data.height = 38; - toolbarComposite.setLayoutData(data); - - data = new FormData(); - data.top = new FormAttachment(toolbarComposite, 0, SWT.BOTTOM); - data.left = new FormAttachment(0, 0); - data.right = new FormAttachment(100, 0); - data.bottom = new FormAttachment(100, 0); - page.setLayoutData(data); + data = new FormData(); + data.top = new FormAttachment(toolbarComposite, 0, SWT.BOTTOM); + data.left = new FormAttachment(0, 0); + data.right = new FormAttachment(100, 0); + data.bottom = new FormAttachment(100, 0); + page.setLayoutData(data); - configurer.getWindow().getShell().layout(true); - if (null != page) { + configurer.getWindow().getShell().layout(true); ((Composite) page).layout(true); } }