From: Fabian Frederick Date: Sat, 28 Jun 2014 13:20:43 +0000 (+0200) Subject: drivers/gpu/drm/drm_buffer.c: remove unnecessary null test before kfree X-Git-Tag: v4.9.8~5935^2~48^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74f20788a7637f03bb877a178ef2c8f34a722c26;p=platform%2Fkernel%2Flinux-rpi3.git drivers/gpu/drm/drm_buffer.c: remove unnecessary null test before kfree This patch removes special case of last element and loops from idx to 0. Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Signed-off-by: Fabian Frederick Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/drm_buffer.c b/drivers/gpu/drm/drm_buffer.c index 0406110..86a4a4a 100644 --- a/drivers/gpu/drm/drm_buffer.c +++ b/drivers/gpu/drm/drm_buffer.c @@ -80,11 +80,7 @@ int drm_buffer_alloc(struct drm_buffer **buf, int size) error_out: - /* Only last element can be null pointer so check for it first. */ - if ((*buf)->data[idx]) - kfree((*buf)->data[idx]); - - for (--idx; idx >= 0; --idx) + for (; idx >= 0; --idx) kfree((*buf)->data[idx]); kfree(*buf);