From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 9 Jan 2012 17:26:05 +0000 (+0100)
Subject: ALSA: asihpi - Fix potential Oops in snd_asihpi_cmode_info()
X-Git-Tag: v3.3-rc1~32^2~7^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74eeb141d3bdf5a9a65c84dd637c41f12c40f41c;p=platform%2Fkernel%2Flinux-3.10.git

ALSA: asihpi - Fix potential Oops in snd_asihpi_cmode_info()

Dan Carpenter reported that setting 0 to uinfo->value.enumerated.items
in snd_asihpi_cmode_info() may lead to Oops.  This function should
return an error immediately in such a case instead.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
index fd3926f..e8de831 100644
--- a/sound/pci/asihpi/asihpi.c
+++ b/sound/pci/asihpi/asihpi.c
@@ -2259,6 +2259,9 @@ static int snd_asihpi_cmode_info(struct snd_kcontrol *kcontrol,
 			valid_modes++;
 			}
 
+	if (!valid_modes)
+		return -EINVAL;
+
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
 	uinfo->count = 1;
 	uinfo->value.enumerated.items = valid_modes;