From: Krzysztof Kozlowski Date: Tue, 1 Sep 2020 15:27:11 +0000 (+0200) Subject: spi: synquacer: Simplify with dev_err_probe() X-Git-Tag: v5.15~2347^2~102 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74ee6dc1257edf5fcfba67fd8075b766d11c42a0;p=platform%2Fkernel%2Flinux-starfive.git spi: synquacer: Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20200901152713.18629-9-krzk@kernel.org Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c index ae17c99c..42e82db 100644 --- a/drivers/spi/spi-synquacer.c +++ b/drivers/spi/spi-synquacer.c @@ -640,9 +640,8 @@ static int synquacer_spi_probe(struct platform_device *pdev) } if (IS_ERR(sspi->clk)) { - if (!(PTR_ERR(sspi->clk) == -EPROBE_DEFER)) - dev_err(&pdev->dev, "clock not found\n"); - ret = PTR_ERR(sspi->clk); + ret = dev_err_probe(&pdev->dev, PTR_ERR(sspi->clk), + "clock not found\n"); goto put_spi; }