From: Somya Anand Date: Fri, 31 Oct 2014 13:00:32 +0000 (+0530) Subject: staging: android: logger: Add a TODO X-Git-Tag: v4.14-rc1~6283^2~493 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74d443bb2d7b9ca387de3c598962be0d4a46b33d;p=platform%2Fkernel%2Flinux-rpi.git staging: android: logger: Add a TODO A comment about a pre-existing bug data structure definition is added. This bug was evidently introduced by Xiong Zhou in the patch bd471258f2e09 ("staging: android: logger: use kuid_t instead of uid_t") where the code was changed to hide a valid build warning instead of solving the bug that was identified by it. Signed-off-by: Somya Anand Reviewed-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO index b15fb0d..06954cd 100644 --- a/drivers/staging/android/TODO +++ b/drivers/staging/android/TODO @@ -5,6 +5,13 @@ TODO: - make sure things build as modules properly - add proper arch dependencies as needed - audit userspace interfaces to make sure they are sane + - kuid_t should never be exposed to user space as it is + kernel internal type. Data structure for this kuid_t is: + typedef struct { + uid_t val; + } kuid_t; + - This bug is introduced by Xiong Zhou in the patch bd471258f2e09 + - ("staging: android: logger: use kuid_t instead of uid_t") Please send patches to Greg Kroah-Hartman and Cc: Brian Swetland