From: Sangpyo Kim Date: Mon, 3 Sep 2012 14:02:14 +0000 (+0900) Subject: [Title] immediately erasing bookmark list item after it is deleted. X-Git-Tag: 2.0_alpha~36 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7465c5cabbb87b17833fc103d79d15e6ad000ee8;p=profile%2Fcommon%2Fapps%2Fweb%2Fbrowser.git [Title] immediately erasing bookmark list item after it is deleted. [Issue#] N_SE-8788 [Problem] crash occured when get a label on the bookmark genlist [Cause] The item memory address is accessed after it is deleted [Solution] immediately erasing bookmark list item after it is deleted. [Team] Browser UI [Developer] sangpyo7.kim [Request] N/A Change-Id: Ic209b9482842a87fa01cdaef61738283f4c02005 --- diff --git a/src/browser-bookmark/browser-bookmark-view.cpp b/src/browser-bookmark/browser-bookmark-view.cpp index 30a522b3..b5265d7d 100755 --- a/src/browser-bookmark/browser-bookmark-view.cpp +++ b/src/browser-bookmark/browser-bookmark-view.cpp @@ -71,14 +71,18 @@ Browser_Bookmark_View::~Browser_Bookmark_View(void) hide_notify_popup(); for(int i = 0 ; i < m_sub_folder_list.size() ; i++ ) { - if (m_sub_folder_list[i]) + if (m_sub_folder_list[i]) { delete m_sub_folder_list[i]; + m_sub_folder_list.erase(m_sub_folder_list.begin() + i); + } } m_sub_folder_list.clear(); for(int i = 0 ; i < m_main_folder_list.size() ; i++ ) { - if (m_main_folder_list[i]) + if (m_main_folder_list[i]) { delete m_main_folder_list[i]; + m_main_folder_list.erase(m_main_folder_list.begin() + i); + } } m_main_folder_list.clear();