From: Yangtao Li Date: Thu, 22 Nov 2018 12:39:24 +0000 (-0500) Subject: ata: pata_macio: add of_node_put() X-Git-Tag: v5.4-rc1~1881^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=745d51dc8a29e00e9ba14e090aa3c8a41e7221d9;p=platform%2Fkernel%2Flinux-rpi.git ata: pata_macio: add of_node_put() of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it. Acked-by: Bartlomiej Zolnierkiewicz Signed-off-by: Yangtao Li Signed-off-by: Jens Axboe --- diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index 9588e68..8cc9c42 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap) struct device_node *root = of_find_node_by_path("/"); const char *model = of_get_property(root, "model", NULL); + of_node_put(root); + if (cable && !strncmp(cable, "80-", 3)) { /* Some drives fail to detect 80c cable in PowerBook * These machine use proprietary short IDE cable