From: Thiago Santos <ts.santos@sisa.samsung.com>
Date: Mon, 7 Jul 2014 19:14:32 +0000 (-0300)
Subject: fdsrc: fix error setting when uri is invalid
X-Git-Tag: 1.3.91~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7446cea73d28e23d99eb6335ca5ca4f976bf3b03;p=platform%2Fupstream%2Fgstreamer.git

fdsrc: fix error setting when uri is invalid

Elements should always set the GError
---

diff --git a/plugins/elements/gstfdsrc.c b/plugins/elements/gstfdsrc.c
index ec7cc35..82b8344 100644
--- a/plugins/elements/gstfdsrc.c
+++ b/plugins/elements/gstfdsrc.c
@@ -631,13 +631,18 @@ gst_fd_src_uri_set_uri (GstURIHandler * handler, const gchar * uri,
 
   protocol = gst_uri_get_protocol (uri);
   if (strcmp (protocol, "fd") != 0) {
+    g_set_error (err, GST_URI_ERROR, GST_URI_ERROR_BAD_URI,
+        "Wrong protocol for fdsrc in uri: '%s'", uri);
     g_free (protocol);
     return FALSE;
   }
   g_free (protocol);
 
-  if (sscanf (uri, "fd://%d", &fd) != 1 || fd < 0)
+  if (sscanf (uri, "fd://%d", &fd) != 1 || fd < 0) {
+    g_set_error (err, GST_URI_ERROR, GST_URI_ERROR_BAD_URI,
+        "Bad file descriptor number in uri: '%s'", uri);
     return FALSE;
+  }
 
   if ((q = g_strstr_len (uri, -1, "?"))) {
     gchar *sp;