From: Yafang Shao Date: Sat, 1 Sep 2018 12:21:05 +0000 (+0800) Subject: tcp: remove useless add operation when init sysctl_max_tw_buckets X-Git-Tag: v5.15~7641^2~455 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=743e481580b4646cde416dd549e2ecb0f16848d2;p=platform%2Fkernel%2Flinux-starfive.git tcp: remove useless add operation when init sysctl_max_tw_buckets cp_hashinfo.ehash_mask is always an odd number, which is set in function alloc_large_system_hash(). See bellow, if (_hash_mask) *_hash_mask = (1 << log2qty) - 1; <<< always odd number Hence the local variable 'cnt' is a even number, as a result of that it is no difference to do the incrementation here. Signed-off-by: Yafang Shao Signed-off-by: David S. Miller --- diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 44c09ed..09547ef 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -2549,7 +2549,7 @@ static int __net_init tcp_sk_init(struct net *net) net->ipv4.sysctl_tcp_tw_reuse = 2; cnt = tcp_hashinfo.ehash_mask + 1; - net->ipv4.tcp_death_row.sysctl_max_tw_buckets = (cnt + 1) / 2; + net->ipv4.tcp_death_row.sysctl_max_tw_buckets = cnt / 2; net->ipv4.tcp_death_row.hashinfo = &tcp_hashinfo; net->ipv4.sysctl_max_syn_backlog = max(128, cnt / 256);