From: Randeep Singh <randeep.s@samsung.com>
Date: Wed, 26 Feb 2020 11:06:15 +0000 (+0530)
Subject: resolved coverity issues
X-Git-Tag: submit/tizen/20200227.122405~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74227690e3ec815b2e43ae45944c7b0bb67f40bd;p=platform%2Fcore%2Fmessaging%2Fmsg-service.git

resolved coverity issues

Change-Id: Ieb742fd7aa7684df22d4170546028c43c6a92e1b
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
---

diff --git a/include/common/MsgCmdTypes.h b/include/common/MsgCmdTypes.h
index da2cdb7..587f5bc 100755
--- a/include/common/MsgCmdTypes.h
+++ b/include/common/MsgCmdTypes.h
@@ -50,7 +50,7 @@ typedef struct _MSG_CMD_S {
 typedef struct _MSG_EVENT_S {
 	MSG_EVENT_TYPE_T		eventType;
 	msg_error_t			result;
-	char					data[2];
+	char				data[2];
 } MSG_EVENT_S;
 
 
diff --git a/proxy/MsgHandleSetting.cpp b/proxy/MsgHandleSetting.cpp
index b42052d..1502020 100755
--- a/proxy/MsgHandleSetting.cpp
+++ b/proxy/MsgHandleSetting.cpp
@@ -80,7 +80,7 @@ msg_error_t MsgHandle::getSMSCOption(msg_struct_t msg_struct)
 		MSG_SMSC_LIST_S smsc_list_tmp = {0, };
 		int dataSize = 0;
 
-		dataSize = sizeof(MSG_SMSC_LIST_S);
+		dataSize = sizeof(pEvent->data);
 		memcpy(&smsc_list_tmp, pEvent->data, dataSize);
 
 		MSG_SMSC_LIST_HIDDEN_S *pTmp = (MSG_SMSC_LIST_HIDDEN_S *)smsc_opt->data;
@@ -348,7 +348,7 @@ msg_error_t MsgHandle::getSmsSendOpt(msg_struct_t msg_struct)
 	}
 
 	if (pEvent->result == MSG_SUCCESS) {
-		memcpy(sms_send_opt->data, pEvent->data, sizeof(MSG_SMS_SENDOPT_S));
+		memcpy(sms_send_opt->data, pEvent->data, sizeof(pEvent->data));
 	}
 
 	return pEvent->result;
@@ -440,7 +440,7 @@ msg_error_t MsgHandle::getMmsSendOpt(msg_struct_t msg_struct)
 	}
 
 	if (pEvent->result == MSG_SUCCESS) {
-		memcpy(mms_send_opt->data, pEvent->data, sizeof(MSG_MMS_SENDOPT_S));
+		memcpy(mms_send_opt->data, pEvent->data, sizeof(pEvent->data));
 	}
 
 	return pEvent->result;
@@ -906,7 +906,7 @@ msg_error_t MsgHandle::getMsgSizeOpt(msg_struct_t msg_struct)
 	}
 
 	if (pEvent->result == MSG_SUCCESS) {
-		memcpy(msg_size_opt->data, pEvent->data, sizeof(MSG_MSGSIZE_OPT_S));
+		memcpy(msg_size_opt->data, pEvent->data, sizeof(pEvent->data));
 	}
 
 	return pEvent->result;