From: Laurent Pinchart Date: Mon, 14 Dec 2015 20:39:39 +0000 (+0200) Subject: drm: omapdrm: gem: Fix GEM object destroy in error path X-Git-Tag: v4.14-rc1~3993^2~14^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74128a237eca99dbca6a8ca47f062b6791441221;p=platform%2Fkernel%2Flinux-rpi.git drm: omapdrm: gem: Fix GEM object destroy in error path Use the omap_gem_free_object() function to destroy the GEM object in the omap_gem_new_handle() error path instead of doing it manually (and incorrectly). Signed-off-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c index d9ce296..b535fed 100644 --- a/drivers/gpu/drm/omapdrm/omap_gem.c +++ b/drivers/gpu/drm/omapdrm/omap_gem.c @@ -1452,8 +1452,7 @@ int omap_gem_new_handle(struct drm_device *dev, struct drm_file *file, ret = drm_gem_handle_create(file, obj, handle); if (ret) { - drm_gem_object_release(obj); - kfree(obj); /* TODO isn't there a dtor to call? just copying i915 */ + omap_gem_free_object(obj); return ret; }