From: Steven Rostedt (Google) Date: Tue, 5 Jul 2022 22:45:04 +0000 (-0400) Subject: scsi: qla2xxx: tracing: Use the new __vstring() helper X-Git-Tag: v6.1-rc5~555^2~44 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=74003fc4ae7619ac5a7bec8748a14f3a8655f3ea;p=platform%2Fkernel%2Flinux-starfive.git scsi: qla2xxx: tracing: Use the new __vstring() helper Instead of open coding a __dynamic_array() with a fixed length (which defeats the purpose of the dynamic array in the first place). Use the new __vstring() helper that will use a va_list and only write enough of the string into the ring buffer that is needed. Link: https://lkml.kernel.org/r/20220705224750.896553364@goodmis.org Cc: Bart Van Assche Cc: Ingo Molnar Cc: Andrew Morton Cc: Martin K. Petersen Signed-off-by: Steven Rostedt (Google) --- diff --git a/include/trace/events/qla.h b/include/trace/events/qla.h index 5857cf6..e7fd55e 100644 --- a/include/trace/events/qla.h +++ b/include/trace/events/qla.h @@ -22,11 +22,11 @@ DECLARE_EVENT_CLASS(qla_log_event, TP_STRUCT__entry( __string(buf, buf) - __dynamic_array(char, msg, QLA_MSG_MAX) + __vstring(msg, vaf->fmt, vaf->va) ), TP_fast_assign( __assign_str(buf, buf); - vsnprintf(__get_str(msg), QLA_MSG_MAX, vaf->fmt, *vaf->va); + __assign_vstr(msg, vaf->fmt, vaf->va); ), TP_printk("%s %s", __get_str(buf), __get_str(msg))