From: Tobias Lorenz Date: Sat, 10 Jul 2010 16:01:33 +0000 (-0300) Subject: V4L/DVB: si470x: -EINVAL overwritten in si470x_vidioc_s_tuner() X-Git-Tag: v2.6.36-rc1~582^2~71 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=73c994e4fb69b7bb85663e5175432c307657d207;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git V4L/DVB: si470x: -EINVAL overwritten in si470x_vidioc_s_tuner() This patch to the si470x_vidioc_s_tuner function was developed in cooperation with Roel Kluin . It sets the default retval to 0 instead of -EINVAL, identical to what is done in all other set/get functions of v4l2_ioctl_ops. This is just as cosmetic change, as retval is directly overwritten by the si470x_disconnect_check() anyway. Signed-off-by: Tobias Lorenz Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/radio/si470x/radio-si470x-common.c b/drivers/media/radio/si470x/radio-si470x-common.c index 47075fc..9927a59 100644 --- a/drivers/media/radio/si470x/radio-si470x-common.c +++ b/drivers/media/radio/si470x/radio-si470x-common.c @@ -748,7 +748,7 @@ static int si470x_vidioc_s_tuner(struct file *file, void *priv, struct v4l2_tuner *tuner) { struct si470x_device *radio = video_drvdata(file); - int retval = -EINVAL; + int retval = 0; /* safety checks */ retval = si470x_disconnect_check(radio);