From: Sakari Ailus Date: Wed, 29 Mar 2023 14:57:50 +0000 (+0100) Subject: media: ov5670: Fix probe on ACPI X-Git-Tag: v6.6.7~3028^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=73b41dc51fbeffa4a216b20193274cfe92b5d95b;p=platform%2Fkernel%2Flinux-starfive.git media: ov5670: Fix probe on ACPI devm_clk_get() will return either an error or NULL, which the driver handles, continuing to use the clock of reading the value of the clock-frequency property. However, the value of ov5670->xvclk is left as-is and the other clock framework functions aren't capable of handling error values. Use devm_clk_get_optional() to obtain NULL instead of -ENOENT. Fixes: 8004c91e2095 ("media: i2c: ov5670: Use common clock framework") Signed-off-by: Sakari Ailus Reviewed-by: Jacopo Mondi Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c index 24c0631..c026610 100644 --- a/drivers/media/i2c/ov5670.c +++ b/drivers/media/i2c/ov5670.c @@ -2691,7 +2691,7 @@ static int ov5670_probe(struct i2c_client *client) if (!ov5670) return -ENOMEM; - ov5670->xvclk = devm_clk_get(&client->dev, NULL); + ov5670->xvclk = devm_clk_get_optional(&client->dev, NULL); if (!IS_ERR_OR_NULL(ov5670->xvclk)) input_clk = clk_get_rate(ov5670->xvclk); else if (!ov5670->xvclk || PTR_ERR(ov5670->xvclk) == -ENOENT)