From: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Thu, 19 Sep 2019 19:09:20 +0000 (-0700)
Subject: gst: encode: h264_fei: remove useless comparison
X-Git-Tag: 1.19.3~503^2~390
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=73ac0c4e502449481f03b7ec7b6282503dfaac6f;p=platform%2Fupstream%2Fgstreamer.git

gst: encode: h264_fei: remove useless comparison

The expression "len >= 0" is always true since "len"
is an unsigned type.  And it is clear that the writers
intention was not to write "len > 0" since we handle
len == 0 in the ensuing "if (len < 3)" conditional
block.
---

diff --git a/gst/vaapi/gstvaapiencode_h264_fei.c b/gst/vaapi/gstvaapiencode_h264_fei.c
index 0b1b74a..c09eaea 100644
--- a/gst/vaapi/gstvaapiencode_h264_fei.c
+++ b/gst/vaapi/gstvaapiencode_h264_fei.c
@@ -241,7 +241,7 @@ _h264_byte_stream_next_nal (guint8 * buffer, guint32 len, guint32 * nal_size)
   guint32 flag = 0xFFFFFFFF;
   guint32 nal_start_len = 0;
 
-  g_assert (len >= 0 && buffer && nal_size);
+  g_assert (buffer && nal_size);
   if (len < 3) {
     *nal_size = len;
     nal_start = (len ? buffer : NULL);