From: Andy Shevchenko Date: Mon, 25 Oct 2021 13:51:48 +0000 (+0300) Subject: tty: rpmsg: Define tty name via constant string literal X-Git-Tag: v6.1-rc5~2726^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=73a3d4f41886e6bd27f8b09c6235539a586e5131;p=platform%2Fkernel%2Flinux-starfive.git tty: rpmsg: Define tty name via constant string literal Driver uses already twice the same string literal. Define it in one place, so every user will have this name consistent. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20211025135148.53944-5-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/rpmsg_tty.c b/drivers/tty/rpmsg_tty.c index 4bee6c5b..dae2a4e 100644 --- a/drivers/tty/rpmsg_tty.c +++ b/drivers/tty/rpmsg_tty.c @@ -18,6 +18,7 @@ #include #include +#define RPMSG_TTY_NAME "ttyRPMSG" #define MAX_TTY_RPMSG 32 static DEFINE_IDR(tty_idr); /* tty instance id */ @@ -172,7 +173,7 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev) dev_set_drvdata(dev, cport); - dev_dbg(dev, "New channel: 0x%x -> 0x%x : ttyRPMSG%d\n", + dev_dbg(dev, "New channel: 0x%x -> 0x%x: " RPMSG_TTY_NAME "%d\n", rpdev->src, rpdev->dst, cport->id); return 0; @@ -224,7 +225,7 @@ static int __init rpmsg_tty_init(void) return PTR_ERR(rpmsg_tty_driver); rpmsg_tty_driver->driver_name = "rpmsg_tty"; - rpmsg_tty_driver->name = "ttyRPMSG"; + rpmsg_tty_driver->name = RPMSG_TTY_NAME; rpmsg_tty_driver->major = 0; rpmsg_tty_driver->type = TTY_DRIVER_TYPE_CONSOLE;