From: Jan Kara <jack@suse.cz>
Date: Tue, 25 Nov 2014 21:23:48 +0000 (-0500)
Subject: ext4: remove never taken branch from ext4_ext_shift_path_extents()
X-Git-Tag: v4.9.8~5045^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=733ded2a803523f9e082282820821343679cadc6;p=platform%2Fkernel%2Flinux-rpi3.git

ext4: remove never taken branch from ext4_ext_shift_path_extents()

path[depth].p_hdr can never be NULL for a path passed to us (and even if
it could, EXT_LAST_EXTENT() would make something != NULL from it). So
just remove the branch.

Coverity-id: 1196498
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index e2424ba..c3a1fa1 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5249,8 +5249,6 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
 				return -EIO;
 
 			ex_last = EXT_LAST_EXTENT(path[depth].p_hdr);
-			if (!ex_last)
-				return -EIO;
 
 			err = ext4_access_path(handle, inode, path + depth);
 			if (err)