From: Łukasz Stelmach <l.stelmach@samsung.com>
Date: Fri, 9 Apr 2021 15:20:07 +0000 (+0200)
Subject: logger: fix temporary buffer handling
X-Git-Tag: submit/tizen/20211126.100737~15^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7306e03c6ae60698f0f361b5d38d9e69712d4cf2;p=platform%2Fkernel%2Flinux-tizen-modules-source.git

logger: fix temporary buffer handling

Prevent writing beyond temporary buffer and improve accumulation of data
before receiving a newline character or filling the buffer.

Change-Id: I8e0591c90914dbd4c2addde4247157831fa4843a
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---

diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index 67608e0..680ec1a 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -593,6 +593,7 @@ static ssize_t logger_write_iter(struct kiocb *iocb, struct iov_iter *from)
 	if (from_stdio) {
 		char *p;
 		size_t chunk_len = 0;
+		/* -2 : priority byte and tag terminating '\0' */
 		size_t max_payload = LOGGER_ENTRY_MAX_PAYLOAD - writer->tag_len - 2;
 
 		if (writer->owner != current->group_leader) {
@@ -623,7 +624,9 @@ static ssize_t logger_write_iter(struct kiocb *iocb, struct iov_iter *from)
 		if (writer->b_owner != current && writer->b_off)
 			flush_thread_data(file);
 
-		count = min_t(size_t, iov_iter_count(from), max_payload - 1);
+		/* -1 : leave space for message terminating '\0' */
+		count = min_t(size_t, iov_iter_count(from),
+			      max_payload - writer->b_off - 1);
 
 		do {
 
@@ -638,8 +641,16 @@ static ssize_t logger_write_iter(struct kiocb *iocb, struct iov_iter *from)
 				*p++ = '\0';
 				chunk_len = p - writer->buffer;
 			} else {
-				writer->buffer[count++] = '\0';
-				chunk_len = count;
+				writer->buffer[writer->b_off + count++] = '\0';
+				p = &writer->buffer[writer->b_off + count];
+				chunk_len = p - writer->buffer;
+
+				BUG_ON(chunk_len > max_payload);
+				if (chunk_len < max_payload ) {
+					writer->b_off = writer->b_off + count - 1;
+					continue;
+				}
+
 			}
 
 			header.len = chunk_len + writer->tag_len + 2;