From: Daniel Vetter Date: Thu, 28 Mar 2013 15:01:35 +0000 (+0100) Subject: drm/i915: check fb->pixel_format instead of bits_per_pixel X-Git-Tag: v3.12-rc1~464^2~131^2~241 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=72f4901e3c9b138d4ba5fd51e93eb97207c6eaca;p=kernel%2Fkernel-generic.git drm/i915: check fb->pixel_format instead of bits_per_pixel We've mostly switched over to the new more flexible schema, but there's one check left in the modeset code. Motivated by a question from Ville whether there's really no way an unsupported pixel_format can escape into our platform update_plane callbacks. v2: Ville noticed that the fb->depth check is redudant when we already check fb->pixel_format. Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 84bd8d3..3f3a3dc 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -7954,10 +7954,8 @@ intel_set_config_compute_mode_changes(struct drm_mode_set *set, config->mode_changed = true; } else if (set->fb == NULL) { config->mode_changed = true; - } else if (set->fb->depth != set->crtc->fb->depth) { - config->mode_changed = true; - } else if (set->fb->bits_per_pixel != - set->crtc->fb->bits_per_pixel) { + } else if (set->fb->pixel_format != + set->crtc->fb->pixel_format) { config->mode_changed = true; } else config->fb_changed = true;