From: Paolo Abeni <pabeni@redhat.com>
Date: Tue, 16 Jan 2024 17:18:47 +0000 (+0100)
Subject: mptcp: relax check on MPC passive fallback
X-Git-Tag: v6.6.14~29
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=72b45857b7241305e362b85255559203d2635fd4;hp=9aeb09f4d85a87bac46c010d75a2ea299d462f28;p=platform%2Fkernel%2Flinux-starfive.git

mptcp: relax check on MPC passive fallback

[ Upstream commit c0f5aec28edf98906d28f08daace6522adf9ee7a ]

While testing the blamed commit below, I was able to miss (!)
packetdrill failures in the fastopen test-cases.

On passive fastopen the child socket is created by incoming TCP MPC syn,
allow for both MPC_SYN and MPC_ACK header.

Fixes: 724b00c12957 ("mptcp: refine opt_mp_capable determination")
Reviewed-by: Matthieu Baerts <matttbe@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 70b7a47a..d3c5ecf 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -783,7 +783,8 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
 		 * options.
 		 */
 		mptcp_get_options(skb, &mp_opt);
-		if (!(mp_opt.suboptions & OPTION_MPTCP_MPC_ACK))
+		if (!(mp_opt.suboptions &
+		      (OPTION_MPTCP_MPC_SYN | OPTION_MPTCP_MPC_ACK)))
 			fallback = true;
 
 	} else if (subflow_req->mp_join) {