From: Christopher Michael <cp.michael@samsung.com>
Date: Tue, 12 Mar 2019 13:57:33 +0000 (-0400)
Subject: elm_config: Fix unchecked return value
X-Git-Tag: submit/tizen/20190402.051338~215
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=728919e2b2b91a8fefa773d97326c346ab5d54eb;p=platform%2Fupstream%2Fefl.git

elm_config: Fix unchecked return value

Small patch to check the return value of ecore_file_cp. Coverity
reports this as an unchecked return value, so let's just add a simple
check here.

Fixes Coverity CID1399101

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8309
---

diff --git a/src/lib/elementary/elm_config.c b/src/lib/elementary/elm_config.c
index 2e34c25..088a5f6 100644
--- a/src/lib/elementary/elm_config.c
+++ b/src/lib/elementary/elm_config.c
@@ -877,7 +877,8 @@ _elm_config_profile_derived_save(const char *profile, Elm_Config_Derived *derive
         eet_close(ef);
         if (ret)
           {
-             ecore_file_cp(buf, buf2);
+             if (!ecore_file_cp(buf, buf2))
+               ERR("Error saving Elementary's derived configuration profile file");
              ecore_file_unlink(buf);
           }
         else