From: Jürg Billeter Date: Fri, 3 Oct 2008 13:53:40 +0000 (+0000) Subject: Always use lowercase signal names in generated C code, patch by X-Git-Tag: VALA_0_4_0~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=728566f220de1d03dde1c14bb6381e1f2ce776d4;p=platform%2Fupstream%2Fvala.git Always use lowercase signal names in generated C code, patch by 2008-10-03 Jürg Billeter * vala/valasignal.vala: * gobject/valaccodetypesymbolbinding.vala: Always use lowercase signal names in generated C code, patch by Marc-André Lureau, fixes bug 549507 svn path=/trunk/; revision=1819 --- diff --git a/ChangeLog b/ChangeLog index 35f422c..266934a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2008-10-03 Jürg Billeter + * vala/valasignal.vala: + * gobject/valaccodetypesymbolbinding.vala: + + Always use lowercase signal names in generated C code, + patch by Marc-André Lureau, fixes bug 549507 + +2008-10-03 Jürg Billeter + * vala/valaclass.vala: * vala/valainterfacewriter.vala: * vala/valatypesymbol.vala: diff --git a/gobject/valaccodetypesymbolbinding.vala b/gobject/valaccodetypesymbolbinding.vala index 1b991e3..821ff65 100644 --- a/gobject/valaccodetypesymbolbinding.vala +++ b/gobject/valaccodetypesymbolbinding.vala @@ -203,7 +203,7 @@ public abstract class Vala.CCodeTypeSymbolBinding : CCodeBinding { public CCodeFunctionCall get_signal_creation (Signal sig, TypeSymbol type) { var csignew = new CCodeFunctionCall (new CCodeIdentifier ("g_signal_new")); - csignew.add_argument (new CCodeConstant ("\"%s\"".printf (sig.name))); + csignew.add_argument (new CCodeConstant ("\"%s\"".printf (sig.get_cname ()))); csignew.add_argument (new CCodeIdentifier (type.get_type_id ())); csignew.add_argument (new CCodeConstant ("G_SIGNAL_RUN_LAST")); csignew.add_argument (new CCodeConstant ("0")); diff --git a/vala/valasignal.vala b/vala/valasignal.vala index b7a2ce0..c09ea4e 100644 --- a/vala/valasignal.vala +++ b/vala/valasignal.vala @@ -124,7 +124,7 @@ public class Vala.Signal : Member, Lockable { */ public string get_cname () { if (cname == null) { - cname = name; + cname = camel_case_to_lower_case (name); } return cname; }