From: Nadav Amit Date: Mon, 4 Jun 2018 13:58:14 +0000 (-0700) Subject: gpio: Fix wrong rounding in gpio-menz127 X-Git-Tag: v4.19~401^2~76 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7279d9917560bbd0d82813d6bf00490a82c06783;p=platform%2Fkernel%2Flinux-rpi.git gpio: Fix wrong rounding in gpio-menz127 men_z127_debounce() tries to round up and down, but uses functions which are only suitable when the divider is a power of two, which is not the case. Use the appropriate ones. Found by static check. Compile tested. Fixes: f436bc2726c64 ("gpio: add driver for MEN 16Z127 GPIO controller") Signed-off-by: Nadav Amit Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c index e103758..b263532 100644 --- a/drivers/gpio/gpio-menz127.c +++ b/drivers/gpio/gpio-menz127.c @@ -56,9 +56,9 @@ static int men_z127_debounce(struct gpio_chip *gc, unsigned gpio, rnd = fls(debounce) - 1; if (rnd && (debounce & BIT(rnd - 1))) - debounce = round_up(debounce, MEN_Z127_DB_MIN_US); + debounce = roundup(debounce, MEN_Z127_DB_MIN_US); else - debounce = round_down(debounce, MEN_Z127_DB_MIN_US); + debounce = rounddown(debounce, MEN_Z127_DB_MIN_US); if (debounce > MEN_Z127_DB_MAX_US) debounce = MEN_Z127_DB_MAX_US;