From: Pawel Czajkowski <p.czajkowski@samsung.com>
Date: Mon, 12 Jan 2015 08:56:24 +0000 (+0100)
Subject: [Datasync] Fix arguments validation
X-Git-Tag: submit/tizen_tv/20150603.064601~1^2~633
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=726c0446601686b8adecc66d5b5010c0720fd7a9;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[Datasync] Fix arguments validation

If validator will throw exceptions, then these changes might be redundant.

[Verification] TCT passrate 64/92.

Change-Id: I99f3b0a0c100c73c80a99996c99c9e89674d6b13
Signed-off-by: Pawel Czajkowski <p.czajkowski@samsung.com>
---

diff --git a/src/datasync/datasync_api.js b/src/datasync/datasync_api.js
index 5582cbe7..51242aab 100644
--- a/src/datasync/datasync_api.js
+++ b/src/datasync/datasync_api.js
@@ -467,10 +467,16 @@ DataSynchronizationManager.prototype.update = function(profile) {
   return native_.getResultObject(msg);
 };
 
-DataSynchronizationManager.prototype.remove = function(profileId) {
+DataSynchronizationManager.prototype.remove = function() {
+  //TODO: delete if validator will throw exceptions
+  if (typeof(arguments[0]) !== 'string') {
+    throw new tizen.WebAPIException(tizen.WebAPIException.NOT_FOUND_ERR);
+  }
+
   var args = validator_.validateArgs(arguments, [
     {name: 'profileId', type: types_.STRING}
   ]);
+
   var msg = native_.callSync('Datasync_remove', {
     profileId: args.profileId
   });
@@ -490,18 +496,23 @@ DataSynchronizationManager.prototype.getMaxProfilesNum = function() {
 };
 
 DataSynchronizationManager.prototype.getProfilesNum = function() {
-   var msg = native_.callSync('Datasync_getProfilesNum');
+  var msg = native_.callSync('Datasync_getProfilesNum');
 
-   if (native_.isFailure(msg)) {
-     throw native_.getErrorObject(msg);
-   }
-   return native_.getResultObject(msg);
+  if (native_.isFailure(msg)) {
+    throw native_.getErrorObject(msg);
+  }
+  return native_.getResultObject(msg);
 };
 
-DataSynchronizationManager.prototype.get = function(profileId) {
+DataSynchronizationManager.prototype.get = function() {
   var args = validator_.validateArgs(arguments, [
     {name: 'profileId', type: types_.STRING}
   ]);
+
+  //TODO: delete if validator will throw exceptions
+  if (typeof(arguments[0]) !== 'string') {
+    throw new tizen.WebAPIException(tizen.WebAPIException.NOT_FOUND_ERR);
+  }
   var msg = native_.callSync('Datasync_get', {
     profileId: args.profileId
   });
@@ -530,19 +541,29 @@ DataSynchronizationManager.prototype.getAll = function() {
   return final;
 };
 
-DataSynchronizationManager.prototype.startSync = function(profileId, progressCallback) {
+DataSynchronizationManager.prototype.startSync = function() {
   var args = validator_.validateArgs(arguments, [
-    {name: 'profileId', type: types_.STRING}
-  ]);
+    {name: 'profileId', type: types_.STRING},
+    {name: 'progressCallback',
+     type: types_.FUNCTION,
+     optional: true,
+     nullable: true
+    }]);
+
+  //TODO: delete if validator will throw exceptions
+  if (typeof(arguments[0]) !== 'string') {
+    throw new tizen.WebAPIException(tizen.WebAPIException.NOT_FOUND_ERR);
+  }
+
   if (arguments.length > 1) {
     // Array is an object, should not accept Array
-    if (progressCallback instanceof Array) {
+    if (args.progressCallback instanceof Array) {
       throw new tizen.WebAPIException(tizen.WebAPIException.TYPE_MISMATCH_ERR);
     }
-    if (typeof progressCallback !== 'object') {
+    if (typeof args.progressCallback !== 'object') {
       throw new tizen.WebAPIException(tizen.WebAPIException.TYPE_MISMATCH_ERR);
     }
-    if (!validateCallbacks(progressCallback)) {
+    if (!validateCallbacks(args.progressCallback)) {
       throw new tizen.WebAPIException(tizen.WebAPIException.TYPE_MISMATCH_ERR);
     }
   }
@@ -557,7 +578,12 @@ DataSynchronizationManager.prototype.startSync = function(profileId, progressCal
   return postSyncMessageWithCallback(msg, progressCallback);
 };
 
-DataSynchronizationManager.prototype.stopSync = function(profileId) {
+DataSynchronizationManager.prototype.stopSync = function() {
+  //TODO: delete if validator will throw exceptions
+  if (typeof(arguments[0]) !== 'string') {
+    throw new tizen.WebAPIException(tizen.WebAPIException.NOT_FOUND_ERR);
+  }
+
   var args = validator_.validateArgs(arguments, [
     {name: 'profileId', type: types_.STRING}
   ]);
@@ -570,10 +596,16 @@ DataSynchronizationManager.prototype.stopSync = function(profileId) {
   return native_.getResultObject(msg);
 };
 
-DataSynchronizationManager.prototype.getLastSyncStatistics = function(profileId) {
+DataSynchronizationManager.prototype.getLastSyncStatistics = function() {
+   //TODO: delete if validator will throw exceptions
+  if (typeof(arguments[0]) !== 'string') {
+    throw new tizen.WebAPIException(tizen.WebAPIException.NOT_FOUND_ERR);
+  }
+
   var args = validator_.validateArgs(arguments, [
     {name: 'profileId', type: types_.STRING}
   ]);
+
   var msg = native_.callSync('Datasync_getLastSyncStatistics', {
     profileId: args.profileId
   });