From: Miklos Szeredi Date: Sat, 15 Aug 2009 06:43:22 +0000 (+0200) Subject: splice: update mtime and atime on files X-Git-Tag: v2.6.32-rc1~688^2~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=723590ed52d244b025f10a8e2f54c2f57ed02b4d;p=profile%2Fivi%2Fkernel-x86-ivi.git splice: update mtime and atime on files Splice should update the modification and access times on regular files just like read and write. Not updating mtime will confuse backup tools, etc... This patch only adds the time updates for regular files. For pipes and other special files that splice touches the need for updating the times is less clear. Let's discuss and fix that separately. Signed-off-by: Miklos Szeredi Signed-off-by: Jens Axboe --- diff --git a/fs/splice.c b/fs/splice.c index 73766d2..aec4014 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -502,8 +502,10 @@ ssize_t generic_file_splice_read(struct file *in, loff_t *ppos, len = left; ret = __generic_file_splice_read(in, ppos, pipe, len, flags); - if (ret > 0) + if (ret > 0) { *ppos += ret; + file_accessed(in); + } return ret; } @@ -963,8 +965,10 @@ generic_file_splice_write(struct pipe_inode_info *pipe, struct file *out, mutex_lock_nested(&inode->i_mutex, I_MUTEX_CHILD); ret = file_remove_suid(out); - if (!ret) + if (!ret) { + file_update_time(out); ret = splice_from_pipe_feed(pipe, &sd, pipe_to_file); + } mutex_unlock(&inode->i_mutex); } while (ret > 0); splice_from_pipe_end(pipe, &sd);