From: Ville Syrjälä Date: Tue, 20 Mar 2012 14:46:17 +0000 (+0200) Subject: gfx: drv: Improve warning messages X-Git-Tag: 2.1b_release~194 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7220802c53b0a6eac7bd8fa6351f5a2ef5fd9901;p=kernel%2Fkernel-mfld-blackbay.git gfx: drv: Improve warning messages Use dev_warn() instead of WARN_ON() to provide better information what went wrong. The message is the important part, the backtrace isn't really useful. Signed-off-by: Ville Syrjälä Signed-off-by: Kirill A. Shutemov --- diff --git a/drivers/staging/mrst/drv/psb_page_flip.c b/drivers/staging/mrst/drv/psb_page_flip.c index 18abb98..e4c339f 100644 --- a/drivers/staging/mrst/drv/psb_page_flip.c +++ b/drivers/staging/mrst/drv/psb_page_flip.c @@ -86,7 +86,10 @@ static u32 get_vbl_count(struct drm_crtc *crtc) low2 = ioread32(reg_pixel) >> PIPE_FRAME_LOW_SHIFT; } while (low1 != low2 && timeout++ < PSB_VBL_CNT_TIMEOUT); - WARN_ON(timeout >= PSB_VBL_CNT_TIMEOUT); + if (timeout >= PSB_VBL_CNT_TIMEOUT) + dev_warn(crtc->dev->dev, + "Timed out while determining VBL count for pipe %d\n", + psb_intel_crtc->pipe); /* * The frame counter seems to increment at the beginning of the @@ -149,7 +152,10 @@ static void avoid_danger_zone(struct drm_crtc *crtc) drm_vblank_put(dev, pipe); - WARN_ON(val >= min && val <= max); + if (val >= min && val <= max) + dev_warn(dev->dev, + "Page flipping close to vblank start (DSL=%u, VBL=%u)\n", + val, crtc->hwmode.crtc_vdisplay); } void