From: Allen Pais Date: Fri, 22 Sep 2017 08:26:46 +0000 (+0530) Subject: drivers: tty: max3100: use setup_timer() helper. X-Git-Tag: v5.15~10045^2~91 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=71fa527290660c5fc6bdc63bcb7de66af4f3895f;p=platform%2Fkernel%2Flinux-starfive.git drivers: tty: max3100: use setup_timer() helper. Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c index ace8264..b6b3453 100644 --- a/drivers/tty/serial/max3100.c +++ b/drivers/tty/serial/max3100.c @@ -787,9 +787,8 @@ static int max3100_probe(struct spi_device *spi) max3100s[i]->poll_time = 1; max3100s[i]->max3100_hw_suspend = pdata->max3100_hw_suspend; max3100s[i]->minor = i; - init_timer(&max3100s[i]->timer); - max3100s[i]->timer.function = max3100_timeout; - max3100s[i]->timer.data = (unsigned long) max3100s[i]; + setup_timer(&max3100s[i]->timer, max3100_timeout, + (unsigned long)max3100s[i]); dev_dbg(&spi->dev, "%s: adding port %d\n", __func__, i); max3100s[i]->port.irq = max3100s[i]->irq;