From: Marc Zyngier Date: Tue, 10 Mar 2020 18:49:18 +0000 (+0000) Subject: irqchip/atmel-aic: Fix irq_retrigger callback return value X-Git-Tag: v5.10.7~2879^2^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7177144a54f594f8815b777ae647e58b07c03f86;p=platform%2Fkernel%2Flinux-rpi.git irqchip/atmel-aic: Fix irq_retrigger callback return value The irq_retrigger callback is supposed to return 0 when retrigger has failed, and a non-zero value otherwise. Tell the core code that the driver has succedded in using the HW to retrigger the interrupt. Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20200310184921.23552-2-maz@kernel.org --- diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c index bb1ad45..2c999dc 100644 --- a/drivers/irqchip/irq-atmel-aic.c +++ b/drivers/irqchip/irq-atmel-aic.c @@ -83,7 +83,7 @@ static int aic_retrigger(struct irq_data *d) irq_reg_writel(gc, d->mask, AT91_AIC_ISCR); irq_gc_unlock(gc); - return 0; + return 1; } static int aic_set_type(struct irq_data *d, unsigned type)