From: Phil Elwell <phil@raspberrypi.org>
Date: Tue, 12 Nov 2019 16:41:21 +0000 (+0000)
Subject: drm/v3d: Plug dma_fence leak
X-Git-Tag: accepted/tizen/unified/20200709.164653~933
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7154554fe21eec7a0d0450c52e64eb34798a2bf2;p=platform%2Fkernel%2Flinux-rpi.git

drm/v3d: Plug dma_fence leak

The irq_fence and done_fence are given a reference that is never
released. The necessary dma_fence_put()s seem to have been
deleted in error in an earlier commit.

Fixes: 0b73676836b2 ("drm/v3d: Clock V3D down when not in use.")

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
---

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 035de14..8b5dc2b2 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -410,6 +410,9 @@ v3d_job_free(struct kref *ref)
 	}
 	xa_destroy(&job->deps);
 
+	dma_fence_put(job->irq_fence);
+	dma_fence_put(job->done_fence);
+
 	v3d_clock_up_put(v3d);
 
 	kfree(job);