From: Ilho Kim <ilho159.kim@samsung.com>
Date: Thu, 17 Feb 2022 02:33:04 +0000 (+0900)
Subject: Fix static analysis issue
X-Git-Tag: accepted/tizen/unified/20220223.132444~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=71460d88717cfa16262fae58cd042b72f1672716;p=platform%2Fcore%2Fappfw%2Fpkgmgr-info.git

Fix static analysis issue

- Uninitialized scalar field

Change-Id: Ic0f2ed78562f9d74f7a8ad346a10384d35419504
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
---

diff --git a/src/server/pkg_request.cc b/src/server/pkg_request.cc
index 0da6300..41b7a59 100644
--- a/src/server/pkg_request.cc
+++ b/src/server/pkg_request.cc
@@ -22,6 +22,9 @@
 
 namespace pkgmgr_server {
 
+PkgRequest::PkgRequest()
+    : request_type_(pkgmgr_common::REQ_TYPE_NONE), data_size_(-1) {}
+
 PkgRequest::PkgRequest(int fd)
     : request_type_(pkgmgr_common::REQ_TYPE_NONE), data_size_(-1) {
   socket_ = std::unique_ptr<pkgmgr_common::socket::DataSocket>(
diff --git a/src/server/pkg_request.hh b/src/server/pkg_request.hh
index ed9ac00..083b8e3 100644
--- a/src/server/pkg_request.hh
+++ b/src/server/pkg_request.hh
@@ -32,7 +32,7 @@ namespace pkgmgr_server {
 
 class EXPORT_API PkgRequest {
  public:
-  PkgRequest() = default;
+  PkgRequest();
   PkgRequest(int fd);
   ~PkgRequest();
 
diff --git a/src/server/request_handler/get_pkginfo_request_handler.hh b/src/server/request_handler/get_pkginfo_request_handler.hh
index 18c6b28..0bf022f 100644
--- a/src/server/request_handler/get_pkginfo_request_handler.hh
+++ b/src/server/request_handler/get_pkginfo_request_handler.hh
@@ -26,7 +26,6 @@ class EXPORT_API GetPkginfoRequestHandler : public AbstractRequestHandler {
 
  private:
   std::shared_ptr<pkgmgr_common::parcel::PkgInfoParcelable> result_;
-  bool cache_;
 };
 
 }  // namespace request_handler