From: Simon Hausmann <simon.hausmann@nokia.com>
Date: Wed, 20 Jul 2011 08:50:21 +0000 (+0200)
Subject: Fix memory leaks with QV8Engine's ExtensionData
X-Git-Tag: qt-v5.0.0-alpha1~2112
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7141596fae74938c907209482a46ecb73df1d4f8;p=profile%2Fivi%2Fqtdeclarative.git

Fix memory leaks with QV8Engine's ExtensionData

The destructor has to be virtual for Deletable in order to call
the destructor of the super-class.

Change-Id: I3aeebe28c0a6bbfbbe3b069e88a6096dd9e173f5
Reviewed-on: http://codereview.qt.nokia.com/1867
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
---

diff --git a/src/declarative/qml/v8/qv8engine_p.h b/src/declarative/qml/v8/qv8engine_p.h
index 6c05fe4..d9f4fee 100644
--- a/src/declarative/qml/v8/qv8engine_p.h
+++ b/src/declarative/qml/v8/qv8engine_p.h
@@ -213,7 +213,7 @@ public:
     ~QV8Engine();
 
     struct Deletable {
-        ~Deletable() {}
+        virtual ~Deletable() {}
     };
 
     void init(QDeclarativeEngine *);