From: Uwe Kleine-König Date: Wed, 15 Mar 2023 15:05:05 +0000 (+0100) Subject: ASoC: adi: axi-i2s: Convert to platform remove callback returning void X-Git-Tag: v6.6.7~2882^2~8^2~110^2~159 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=711c5b4e36a3345cd0de597a9c5b7f5911abfd51;p=platform%2Fkernel%2Flinux-starfive.git ASoC: adi: axi-i2s: Convert to platform remove callback returning void The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Takashi Iwai Acked-by: Nicolas Ferre Link: https://lore.kernel.org/r/20230315150745.67084-14-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown --- diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c index b134235..d5b6f51 100644 --- a/sound/soc/adi/axi-i2s.c +++ b/sound/soc/adi/axi-i2s.c @@ -274,13 +274,11 @@ err_clk_disable: return ret; } -static int axi_i2s_dev_remove(struct platform_device *pdev) +static void axi_i2s_dev_remove(struct platform_device *pdev) { struct axi_i2s *i2s = platform_get_drvdata(pdev); clk_disable_unprepare(i2s->clk); - - return 0; } static const struct of_device_id axi_i2s_of_match[] = { @@ -295,7 +293,7 @@ static struct platform_driver axi_i2s_driver = { .of_match_table = axi_i2s_of_match, }, .probe = axi_i2s_probe, - .remove = axi_i2s_dev_remove, + .remove_new = axi_i2s_dev_remove, }; module_platform_driver(axi_i2s_driver);