From: ulan@chromium.org Date: Fri, 27 Dec 2013 14:38:00 +0000 (+0000) Subject: ARM: fix loading of global object in LWrapReceiver. X-Git-Tag: upstream/4.7.83~11290 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=711bcbb0e3b6ff73a65b504947241e636b3db4d6;p=platform%2Fupstream%2Fv8.git ARM: fix loading of global object in LWrapReceiver. Since r16993 the cp register is handled by registers allocator, and we cannot assume that the cp always contains the context. BUG=318420 LOG=Y TEST=test/mjsunit/regress/regress-318420.js R=verwaest@chromium.org Review URL: https://codereview.chromium.org/121703002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18421 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc index ade6928..2919eb0 100644 --- a/src/arm/lithium-codegen-arm.cc +++ b/src/arm/lithium-codegen-arm.cc @@ -3494,7 +3494,9 @@ void LCodeGen::DoWrapReceiver(LWrapReceiver* instr) { __ b(&result_in_receiver); __ bind(&global_object); - __ ldr(result, GlobalObjectOperand()); + + __ ldr(result, MemOperand(fp, StandardFrameConstants::kContextOffset)); + __ ldr(result, ContextOperand(result, Context::GLOBAL_OBJECT_INDEX)); __ ldr(result, FieldMemOperand(result, JSGlobalObject::kGlobalReceiverOffset)); if (result.is(receiver)) { diff --git a/test/mjsunit/regress/regress-318420.js b/test/mjsunit/regress/regress-318420.js new file mode 100644 index 0000000..77bef10 --- /dev/null +++ b/test/mjsunit/regress/regress-318420.js @@ -0,0 +1,46 @@ +// Copyright 2013 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Flags: --allow-natives-syntax + +function bar(a, b) { with(a) {return a + b;} } + +var obj = { + functions: [bar, bar, bar, bar], + receivers: [bar, bar, undefined, null], + foo: function () { + for (var a = this.functions, e = this.receivers, c = a.length, + d = 0; d < c ; d++) { + a[d].apply(e[d], arguments) + } + } +} + +obj.foo(1, 2, 3, 4); +obj.foo(1, 2, 3, 4); +%OptimizeFunctionOnNextCall(obj.foo); +obj.foo(1, 2, 3, 4);