From: surya.kumar7 Date: Fri, 14 Dec 2018 14:43:18 +0000 (+0530) Subject: fixup! Fix for supporting TCT X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7105a5a7e2b5cf0f53e68ba1d932df93b231f59d;p=platform%2Fframework%2Fweb%2Fcrosswalk-tizen.git fixup! Fix for supporting TCT 1. Unless EWK APIs are used to retrieve EWK specific data, SIGABRT is thrown while trying to delete them 2. An incorrect API and parameter has been modified Change-Id: I4d45fd7e396f7e9581e063216d8fe5b172328aeb Signed-off-by: surya.kumar7 --- diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc index 2f685b54c..fee8f1026 100644 --- a/atom/browser/api/atom_api_web_contents.cc +++ b/atom/browser/api/atom_api_web_contents.cc @@ -966,14 +966,14 @@ void WebContents::HandleWrtPluginMessage(Ewk_Wrt_Message_Data* msg) { if (TYPE_BEGIN("xwalk://")) { extension_server->HandleIPCMessage(msg); } else { - Eina_Stringshare* msg_id = msg->GetId(); - Eina_Stringshare* msg_ref_id = msg->GetReferenceId(); - Eina_Stringshare* msg_value = msg->GetValue(); + Eina_Stringshare* msg_id = ewk_ipc_wrt_message_data_id_get(msg); + Eina_Stringshare* msg_ref_id = ewk_ipc_wrt_message_data_reference_id_get(msg); + Eina_Stringshare* msg_value = ewk_ipc_wrt_message_data_value_get(msg); if (TYPE_IS("tizen://exit")) { atom::Browser::Get()->Quit(); } else if (TYPE_IS("tizen://deleteAllCookies")) { atom::Browser::Get()->ClearCookie(); - extension_server->SendWrtMessage(msg_type, msg_ref_id, "success"); + extension_server->SendWrtMessage(msg_type, msg_id, "success"); } eina_stringshare_del(msg_ref_id); eina_stringshare_del(msg_id); diff --git a/tizen/extensions/common/xwalk_extension_server.cc b/tizen/extensions/common/xwalk_extension_server.cc index f86710292..e4b4b03da 100644 --- a/tizen/extensions/common/xwalk_extension_server.cc +++ b/tizen/extensions/common/xwalk_extension_server.cc @@ -140,7 +140,7 @@ void XWalkExtensionServer::SendWrtMessage( Eina_Stringshare* type, Eina_Stringshare* id, const char* val) { Ewk_IPC_Wrt_Message_Data* ans = ewk_ipc_wrt_message_data_new(); ewk_ipc_wrt_message_data_type_set(ans, type); - ewk_ipc_wrt_message_data_id_set(ans, id); + ewk_ipc_wrt_message_data_reference_id_set(ans, id); ewk_ipc_wrt_message_data_value_set(ans, val); WrtWidgetHost::Get()->SendWrtMessage(*ans); ewk_ipc_wrt_message_data_del(ans);