From: Florian Hahn <flo@fhahn.com>
Date: Wed, 2 Oct 2019 08:15:31 +0000 (+0000)
Subject: [GlobalOpt] Pass DTU to removeUnreachableBlocks instead of recomputing.
X-Git-Tag: llvmorg-11-init~7796
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=70f70035484ba199a329f9f8d9bd67e37bc2b408;p=platform%2Fupstream%2Fllvm.git

[GlobalOpt] Pass DTU to removeUnreachableBlocks instead of recomputing.

removeUnreachableBlocks knows how to preserve the DomTree, so make use
of it instead of re-computing the DT.

Reviewers: davide, kuhar, brzycki

Reviewed By: davide, kuhar

Differential Revision: https://reviews.llvm.org/D68298

llvm-svn: 373430
---

diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
index 9c7fd5e..dfbb3e7 100644
--- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp
+++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
@@ -2285,14 +2285,10 @@ OptimizeFunctions(Module &M,
     // So, remove unreachable blocks from the function, because a) there's
     // no point in analyzing them and b) GlobalOpt should otherwise grow
     // some more complicated logic to break these cycles.
-    // Removing unreachable blocks might invalidate the dominator so we
-    // recalculate it.
     if (!F->isDeclaration()) {
-      if (removeUnreachableBlocks(*F)) {
-        auto &DT = LookupDomTree(*F);
-        DT.recalculate(*F);
-        Changed = true;
-      }
+      auto &DT = LookupDomTree(*F);
+      DomTreeUpdater DTU(DT, DomTreeUpdater::UpdateStrategy::Lazy);
+      Changed |= removeUnreachableBlocks(*F, nullptr, &DTU);
     }
 
     Changed |= processGlobal(*F, GetTLI, LookupDomTree);