From: David Tenty Date: Wed, 11 Dec 2019 22:21:54 +0000 (-0500) Subject: Don't call export_symbols.py with duplicate libs X-Git-Tag: llvmorg-11-init~2376 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=70d14255dfcd9c4849deff9e9f2912c8ec030d11;p=platform%2Fupstream%2Fllvm.git Don't call export_symbols.py with duplicate libs Summary: export_symbols.py discards duplicate symbols, assuming they have public definitions, so if we end up calling it with duplicate libraries we will end up with an inaccurate export list. Reviewers: jasonliu, stevewan, john.brawn Reviewed By: john.brawn Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70918 --- diff --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake index 518ea60..34f532c 100644 --- a/llvm/cmake/modules/AddLLVM.cmake +++ b/llvm/cmake/modules/AddLLVM.cmake @@ -873,6 +873,7 @@ function(export_executable_symbols target) set(new_libs ${newer_libs}) set(newer_libs "") endwhile() + list(REMOVE_DUPLICATES static_libs) if (MSVC) set(mangling microsoft) else()