From: Stefan Sauer Date: Sun, 11 Jan 2015 22:00:29 +0000 (+0100) Subject: preset: fix sorting presets X-Git-Tag: 1.6.1~600 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=70788b857860789ea764ea117cb1b78522ef2b57;p=platform%2Fupstream%2Fgstreamer.git preset: fix sorting presets The glib docs are not clear on this, but the qsort man-page is - the GCompareDataFunc does not get the strings, but pointers to them. --- diff --git a/gst/gstpreset.c b/gst/gstpreset.c index ee5a4a5..d105d9d 100644 --- a/gst/gstpreset.c +++ b/gst/gstpreset.c @@ -428,6 +428,12 @@ preset_get_keyfile (GstPreset * preset) return presets; } +static gint +compare_strings (gchar ** a, gchar ** b, gpointer user_data) +{ + return g_strcmp0 (*a, *b); +} + /* get a list of all supported preset names for an element */ static gchar ** gst_preset_default_get_preset_names (GstPreset * preset) @@ -464,7 +470,7 @@ gst_preset_default_get_preset_names (GstPreset * preset) /* sort the array now */ g_qsort_with_data (groups, num_groups, sizeof (gchar *), - (GCompareDataFunc) strcmp, NULL); + (GCompareDataFunc) compare_strings, NULL); return groups;