From: Pan Bian <bianpan2016@163.com>
Date: Wed, 20 Jan 2021 08:51:13 +0000 (-0800)
Subject: fs/affs: release old buffer head on error path
X-Git-Tag: accepted/tizen/unified/20230118.172025~7867^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=70779b897395b330ba5a47bed84f94178da599f9;p=platform%2Fkernel%2Flinux-rpi.git

fs/affs: release old buffer head on error path

The reference count of the old buffer head should be decremented on path
that fails to get the new buffer head.

Fixes: 6b4657667ba0 ("fs/affs: add rename exchange")
CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index 41c5749..5400a87 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -460,8 +460,10 @@ affs_xrename(struct inode *old_dir, struct dentry *old_dentry,
 		return -EIO;
 
 	bh_new = affs_bread(sb, d_inode(new_dentry)->i_ino);
-	if (!bh_new)
+	if (!bh_new) {
+		affs_brelse(bh_old);
 		return -EIO;
+	}
 
 	/* Remove old header from its parent directory. */
 	affs_lock_dir(old_dir);