From: Nicholas Clark <nick@ccl4.org>
Date: Mon, 19 Sep 2005 21:02:02 +0000 (+0000)
Subject: The second argument to Move() is the destination, so cannot possibly
X-Git-Tag: accepted/trunk/20130322.191538~19854
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=706aa1c9997955fcf6fd0bef3a5f89c64f6802fe;p=platform%2Fupstream%2Fperl.git

The second argument to Move() is the destination, so cannot possibly
be const. Pesky casting in handy.h. Getting in the way of correctness.

p4raw-id: //depot/perl@25502
---

diff --git a/sv.c b/sv.c
index 4ebdc10..24c497d 100644
--- a/sv.c
+++ b/sv.c
@@ -4606,7 +4606,7 @@ Perl_sv_force_normal_flags(pTHX_ register SV *sv, U32 flags)
 	    SvPV_set(sv, Nullch);
 	    SvLEN_set(sv, 0);
 	    SvGROW(sv, len + 1);
-	    Move(pvx,SvPVX_const(sv),len,char);
+	    Move(pvx,SvPVX(sv),len,char);
 	    *SvEND(sv) = '\0';
 	    unshare_hek(SvSHARED_HEK_FROM_PV(pvx));
 	}
@@ -4665,7 +4665,7 @@ Perl_sv_chop(pTHX_ register SV *sv, register const char *ptr)
 	    const char *pvx = SvPVX_const(sv);
 	    const STRLEN len = SvCUR(sv);
 	    SvGROW(sv, len + 1);
-	    Move(pvx,SvPVX_const(sv),len,char);
+	    Move(pvx,SvPVX(sv),len,char);
 	    *SvEND(sv) = '\0';
 	}
 	SvIV_set(sv, 0);
@@ -7937,7 +7937,7 @@ Perl_sv_pvn_force_flags(pTHX_ SV *sv, STRLEN *lp, I32 flags)
 		sv_unref(sv);
 	    SvUPGRADE(sv, SVt_PV);		/* Never FALSE */
 	    SvGROW(sv, len + 1);
-	    Move(s,SvPVX_const(sv),len,char);
+	    Move(s,SvPVX(sv),len,char);
 	    SvCUR_set(sv, len);
 	    *SvEND(sv) = '\0';
 	}