From: Jihoon Kim <jihoon48.kim@samsung.com>
Date: Wed, 16 Jan 2019 01:58:11 +0000 (+0900)
Subject: Fix issue detected by static analysis tool
X-Git-Tag: accepted/tizen/unified/20190117.054727~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=703818b80a38c028a7688c6f725545efd55e1479;p=platform%2Fcore%2Fuifw%2Fisf.git

Fix issue detected by static analysis tool

After having been compared to NULL value at isf_query_utility.cpp:275, pointer 'databaseInfo.pHandle' is dereferenced at isf_query_utility.cpp:286 by calling function 'sqlite3_exec'.

Change-Id: I107205f712bc4ec16f2296fbbd41d3db5bdc70e3
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
---

diff --git a/ism/src/isf_query_utility.cpp b/ism/src/isf_query_utility.cpp
index 5d3a274..aa27c53 100644
--- a/ism/src/isf_query_utility.cpp
+++ b/ism/src/isf_query_utility.cpp
@@ -281,11 +281,11 @@ static inline int _db_init(void)
             LOGE ("sqlite3_exec returned %d: %s", ret, pException);
             sqlite3_free(pException);
         }
-    }
 
-    if (SQLITE_CORRUPT == sqlite3_exec(databaseInfo.pHandle, "pragma integrity_check", _db_integrity_check_cb, NULL, NULL)) {
-        databaseInfo.need_reset = true;
-        LOGE ("DB has been corrupted.");
+        if (SQLITE_CORRUPT == sqlite3_exec(databaseInfo.pHandle, "pragma integrity_check", _db_integrity_check_cb, NULL, NULL)) {
+            databaseInfo.need_reset = true;
+            LOGE ("DB has been corrupted.");
+        }
     }
 
     return 0;