From: Pedro Alves Date: Fri, 19 Apr 2013 15:21:24 +0000 (+0000) Subject: mips-tdep.c: Wrong signness for local holding PC register. X-Git-Tag: cygwin-64bit-premerge~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=70242eb16c06c7fcc080003af6c17ad9dfd634c1;p=platform%2Fupstream%2Fbinutils.git mips-tdep.c: Wrong signness for local holding PC register. Addresses on MIPS are signed, and we're indeed using regcache_cooked_read_signed to read the PC, but, we're passing it the address of an unsigned variable, which triggers a -Wpointer-sign warning. I've chosen to change the variable's type. I believe this will end up being the same (though I can't test it). gdb/ 2013-04-19 Pedro Alves * mips-tdep.c (mips_read_pc): Change local 'pc' type to LONGEST. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index cfd5449..9314749 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2013-04-19 Pedro Alves + * mips-tdep.c (mips_read_pc): Change local 'pc' type to LONGEST. + +2013-04-19 Pedro Alves + * mep-tdep.c (mep_get_insn): Change 'insn' parameter type to unsigned long *. diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 8e5d5d2..245ffd6 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -1245,7 +1245,7 @@ static CORE_ADDR mips_read_pc (struct regcache *regcache) { int regnum = gdbarch_pc_regnum (get_regcache_arch (regcache)); - ULONGEST pc; + LONGEST pc; regcache_cooked_read_signed (regcache, regnum, &pc); if (is_compact_addr (pc))