From: mstarzinger@chromium.org <mstarzinger@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Date: Thu, 7 Aug 2014 11:01:02 +0000 (+0000)
Subject: Remove dangerous default parameter from machine Store operator.
X-Git-Tag: upstream/4.7.83~7743
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6fce0d4df3a56dc6c67ca7505f1e1e7f1a3177ea;p=platform%2Fupstream%2Fv8.git

Remove dangerous default parameter from machine Store operator.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/451593002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22970 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
---

diff --git a/src/compiler/machine-node-factory.h b/src/compiler/machine-node-factory.h
index 8e11815..8d1cf87 100644
--- a/src/compiler/machine-node-factory.h
+++ b/src/compiler/machine-node-factory.h
@@ -100,7 +100,7 @@ class MachineNodeFactory {
     Store(rep, base, Int32Constant(0), value);
   }
   void Store(MachineRepresentation rep, Node* base, Node* index, Node* value) {
-    NEW_NODE_3(MACHINE()->Store(rep), base, index, value);
+    NEW_NODE_3(MACHINE()->Store(rep, kNoWriteBarrier), base, index, value);
   }
   // Arithmetic Operations.
   Node* WordAnd(Node* a, Node* b) {
diff --git a/src/compiler/machine-operator.h b/src/compiler/machine-operator.h
index d0691d1..2328e2b 100644
--- a/src/compiler/machine-operator.h
+++ b/src/compiler/machine-operator.h
@@ -87,8 +87,7 @@ class MachineOperatorBuilder {
     OP1(Load, MachineRepresentation, rep, Operator::kNoWrite, 2, 1);
   }
   // store [base + index], value
-  Operator* Store(MachineRepresentation rep,
-                  WriteBarrierKind kind = kNoWriteBarrier) {
+  Operator* Store(MachineRepresentation rep, WriteBarrierKind kind) {
     StoreRepresentation store_rep = {rep, kind};
     OP1(Store, StoreRepresentation, store_rep, Operator::kNoRead, 3, 0);
   }
diff --git a/test/cctest/compiler/test-changes-lowering.cc b/test/cctest/compiler/test-changes-lowering.cc
index 9efd7d2..3eec14a 100644
--- a/test/cctest/compiler/test-changes-lowering.cc
+++ b/test/cctest/compiler/test-changes-lowering.cc
@@ -213,7 +213,8 @@ TEST(RunChangeTaggedToFloat64) {
   double result;
 
   t.BuildStoreAndLower(t.simplified()->ChangeTaggedToFloat64(),
-                       t.machine()->Store(kMachineFloat64), &result);
+                       t.machine()->Store(kMachineFloat64, kNoWriteBarrier),
+                       &result);
 
   if (Pipeline::SupportedTarget()) {
     FOR_INT32_INPUTS(i) {
diff --git a/test/cctest/compiler/test-machine-operator-reducer.cc b/test/cctest/compiler/test-machine-operator-reducer.cc
index 634e72e..c79a96a 100644
--- a/test/cctest/compiler/test-machine-operator-reducer.cc
+++ b/test/cctest/compiler/test-machine-operator-reducer.cc
@@ -639,8 +639,8 @@ TEST(ReduceLoadStore) {
   }
 
   {
-    Node* store =
-        R.graph.NewNode(R.machine.Store(kMachineWord32), base, index, load);
+    Node* store = R.graph.NewNode(
+        R.machine.Store(kMachineWord32, kNoWriteBarrier), base, index, load);
     MachineOperatorReducer reducer(&R.graph);
     Reduction reduction = reducer.Reduce(store);
     CHECK(!reduction.Changed());  // stores should not be reduced.