From: Su Hui Date: Fri, 12 Jan 2024 04:19:27 +0000 (+0800) Subject: scsi: isci: Fix an error code problem in isci_io_request_build() X-Git-Tag: v6.6.17~190 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6f8277017dfb51f730b37689d60591c9543b4064;p=platform%2Fkernel%2Flinux-starfive.git scsi: isci: Fix an error code problem in isci_io_request_build() [ Upstream commit 658365c6b0857e6a306436e315a8633937e3af42 ] Clang static complains that Value stored to 'status' is never read. Return 'status' rather than 'SCI_SUCCESS'. Fixes: f1f52e75939b ("isci: uplevel request infrastructure") Signed-off-by: Su Hui Link: https://lore.kernel.org/r/20240112041926.3924315-1-suhui@nfschina.com Reviewed-by: Artur Paszkiewicz Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c index a7b3243..7162a50 100644 --- a/drivers/scsi/isci/request.c +++ b/drivers/scsi/isci/request.c @@ -3390,7 +3390,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost, return SCI_FAILURE; } - return SCI_SUCCESS; + return status; } static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)