From: Mathieu Duponchelle <mathieu@centricular.com>
Date: Tue, 27 Feb 2018 19:34:49 +0000 (+0100)
Subject: rtspclientsink: if OPEN failed, unqueue next command
X-Git-Tag: 1.19.3~495^2~309
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6f308daa5faa6e9dc2fc3da69b90434ea8e25b0c;p=platform%2Fupstream%2Fgstreamer.git

rtspclientsink: if OPEN failed, unqueue next command

As READY_TO_PAUSED can no longer return async, the RECORD
command will be queued before the OPEN command fails
(for example in case the server could not be connected),
and record then waits for ever.

https://bugzilla.gnome.org/show_bug.cgi?id=793896
---

diff --git a/gst/rtsp-sink/gstrtspclientsink.c b/gst/rtsp-sink/gstrtspclientsink.c
index 454c58d..358b4e6 100644
--- a/gst/rtsp-sink/gstrtspclientsink.c
+++ b/gst/rtsp-sink/gstrtspclientsink.c
@@ -4684,7 +4684,9 @@ gst_rtsp_client_sink_thread (GstRTSPClientSink * sink)
 
   switch (cmd) {
     case CMD_OPEN:
-      gst_rtsp_client_sink_open (sink, TRUE);
+      if (gst_rtsp_client_sink_open (sink, TRUE) == GST_RTSP_ERROR)
+        gst_rtsp_client_sink_loop_send_cmd (sink, CMD_WAIT,
+            CMD_ALL & ~CMD_CLOSE);
       break;
     case CMD_RECORD:
       gst_rtsp_client_sink_record (sink, TRUE);