From: Ming Lei Date: Sat, 4 Aug 2012 04:01:24 +0000 (+0800) Subject: firmware loader: fix comments on request_firmware_nowait X-Git-Tag: upstream/snapshot3+hdmi~6594^2~79 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6f21a62a58bc3c80cd8b05cacb55003cccd4863e;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git firmware loader: fix comments on request_firmware_nowait request_firmware_nowait is allowed to be called in atomic context now if @gfp is GFP_ATOMIC, so fix the obsolete comments and states which situations are suitable for using it. Signed-off-by: Ming Lei Cc: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 7d3a83b..a47266c 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -846,9 +846,13 @@ static void request_firmware_work_func(struct work_struct *work) * * Caller must hold the reference count of @device. * - * Asynchronous variant of request_firmware() for user contexts where - * it is not possible to sleep for long time. It can't be called - * in atomic contexts. + * Asynchronous variant of request_firmware() for user contexts: + * - sleep for as small periods as possible since it may + * increase kernel boot time of built-in device drivers + * requesting firmware in their ->probe() methods, if + * @gfp is GFP_KERNEL. + * + * - can't sleep at all if @gfp is GFP_ATOMIC. **/ int request_firmware_nowait(