From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 15 Dec 2009 19:07:31 +0000 (+0100)
Subject: regulator: wm831x_reg_read() failure unnoticed in wm831x_aldo_get_mode()
X-Git-Tag: upstream/snapshot3+hdmi~16097^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6f17c65240e35ae99319c659c74d54100a832f45;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

regulator: wm831x_reg_read() failure unnoticed in wm831x_aldo_get_mode()

ret should be signed to notice a failure in wm831x_reg_read().

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
---

diff --git a/drivers/regulator/wm831x-ldo.c b/drivers/regulator/wm831x-ldo.c
index 902db56..61e02ac 100644
--- a/drivers/regulator/wm831x-ldo.c
+++ b/drivers/regulator/wm831x-ldo.c
@@ -470,7 +470,7 @@ static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev)
 	struct wm831x_ldo *ldo = rdev_get_drvdata(rdev);
 	struct wm831x *wm831x = ldo->wm831x;
 	int on_reg = ldo->base + WM831X_LDO_ON_CONTROL;
-	unsigned int ret;
+	int ret;
 
 	ret = wm831x_reg_read(wm831x, on_reg);
 	if (ret < 0)