From: Fam Zheng Date: Tue, 27 Sep 2016 11:14:52 +0000 (+0800) Subject: block: Turn on "unmap" in active commit X-Git-Tag: TizenStudio_2.0_p2.3.2~9^2~14^2~5^2~82^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6f13acf97efb8aade2ff7e0444c15512f9e65812;p=sdk%2Femulator%2Fqemu.git block: Turn on "unmap" in active commit We already specified BDRV_O_UNMAP when opening images in 'qemu-img commit', but didn't turn on the "unmap" in the active commit job. This patch fixes that so that zeroed clusters in top image can be discarded which is desired in the virt-sparsify use case, where a temporary overlay is created and fstrim'ed before commiting back, to free space in the original image. This also enables it for block-commit. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Message-id: 1474974892-5031-1-git-send-email-famz@redhat.com Signed-off-by: Jeff Cody --- diff --git a/block/mirror.c b/block/mirror.c index 7e99f3a..82a9529 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1081,7 +1081,7 @@ void commit_active_start(const char *job_id, BlockDriverState *bs, mirror_start_job(job_id, bs, base, NULL, speed, 0, 0, MIRROR_LEAVE_BACKING_CHAIN, - on_error, on_error, false, cb, opaque, &local_err, + on_error, on_error, true, cb, opaque, &local_err, &commit_active_job_driver, false, base, auto_complete); if (local_err) { error_propagate(errp, local_err);